Nftables improvements #3517
Open
Nftables improvements #3517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created nftables syntax highlighting
JoeKar
reviewed
Oct 23, 2024
Comment on lines
-14
to
15
| - symbol: "[-=/:;,@]" | ||
| - symbol: "([-=/:;,@]|[!=])" | ||
| - symbol.operator: "[<>.&|^!]|\\b(and|ge|gt|le|lt|or|xor)\\b" |
There was a problem hiding this comment.
== and != are comparison operators, so why not adding them to symbol.operator? I even suggest to do the same with - and =.
Example (from C):
Line 23 in b3227d6
There was a problem hiding this comment.
That was a Suggestion on the old PR. I will change it later. It will make more sense to add it to the operators
There was a problem hiding this comment.
I only gave examples. Never mind...
We should add all operators from symbol to symbol.operator, like -, +, *, /, etc.
There was a problem hiding this comment.
I am working right now on it, should i move the symbols =, :, ;, , and @ also to symbol.operator? I have now added -, +, *, /.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See also old PR: #3325