Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Riddley appears to be incompatible with the mranderson #31

Open
byrongibby opened this issue Aug 6, 2019 · 0 comments
Open

Riddley appears to be incompatible with the mranderson #31

byrongibby opened this issue Aug 6, 2019 · 0 comments

Comments

@byrongibby
Copy link

byrongibby commented Aug 6, 2019 •
edited
Loading

Riddley appears to be incompatible with mranderson

It seems that the cause is related to the fact that

both walk.clj and compiler.clj is duplicated which I guess confuses mranderson when it unzips the jar. I am guessing the reason the jar is looks like this is this line in riddley's project file: :java-source-paths ["src/riddley"]

in riddley 0.1.12 (but a similar error is produced in 0.2.0 by mranderson you can view the error here: benedekfazekas/mranderson#44)

.m2/repository/riddley/riddley/0.1.12/riddley-0.1.12.jar
  Length      Date    Time    Name
---------  ---------- -----   ----
      117  01-05-2016 23:37   META-INF/MANIFEST.MF
     2683  01-05-2016 23:37   META-INF/maven/riddley/riddley/pom.xml
      561  01-05-2016 23:37   META-INF/leiningen/riddley/riddley/project.clj
      561  01-05-2016 23:37   project.clj
     2135  01-05-2016 23:37   META-INF/leiningen/riddley/riddley/README.md
        0  01-05-2016 23:37   META-INF/
        0  01-05-2016 23:37   META-INF/maven/
        0  01-05-2016 23:37   META-INF/maven/riddley/
        0  01-05-2016 23:37   META-INF/maven/riddley/riddley/
      143  01-05-2016 23:37   META-INF/maven/riddley/riddley/pom.properties
        0  01-05-2016 23:37   riddley/
     1040  01-05-2016 23:37   riddley/Util.class
     6148  09-07-2013 11:11   riddley/.DS_Store
     2098  10-30-2013 16:15   riddley/compiler.clj
      495  09-01-2013 22:03   riddley/Util.java
     8564  01-05-2016 15:26   riddley/walk.clj
     2098  10-30-2013 16:15   compiler.clj
      495  09-01-2013 22:03   Util.java
     8564  01-05-2016 15:26   walk.clj
---------                     -------
    35702                     19 files

It could be argued that that the uberjar should not look like this. What is the rationale for this and could it be 'fixed'?
@byrongibby byrongibby mentioned this issue Aug 6, 2019
Closed
miikka pushed a commit to miikka/riddley that referenced this issue Oct 9, 2019
Fix :java-source-paths
127b0fb 
This patch fixes the problem reported in issue ztellman#31 where the riddley JAR
would include the source files in the JAR root.

After this change, the JAR contents look like this:

    Archive:  target/riddley-0.2.0.jar
      Length      Date    Time    Name
    ---------  ---------- -----   ----
          229  10-09-2019 20:54   META-INF/MANIFEST.MF
         2740  10-09-2019 20:54   META-INF/maven/riddley/riddley/pom.xml
          606  10-09-2019 20:54   META-INF/leiningen/riddley/riddley/project.clj
         2131  10-09-2019 20:54   META-INF/leiningen/riddley/riddley/README.md
            0  10-09-2019 20:54   META-INF/
            0  10-09-2019 20:54   META-INF/maven/
            0  10-09-2019 20:54   META-INF/maven/riddley/
            0  10-09-2019 20:54   META-INF/maven/riddley/riddley/
          141  10-09-2019 20:54   META-INF/maven/riddley/riddley/pom.properties
            0  10-09-2019 20:54   riddley/
         1040  10-09-2019 20:54   riddley/Util.class
         9757  10-09-2019 20:45   riddley/walk.clj
          495  10-09-2019 20:45   riddley/Util.java
         2098  10-09-2019 20:45   riddley/compiler.clj
    ---------                     -------
        19237                     14 files

ztellman#31.
@miikka miikka mentioned this issue Oct 9, 2019
Open
@ivarref ivarref mentioned this issue Feb 11, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@byrongibby