Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create integration tests to improve reliability when working with jj #11

Open
zschreur opened this issue Jun 14, 2024 · 0 comments
Open
Labels
enhancement New feature or request

Comments

@zschreur
Copy link
Owner

The way we parse jj's cli output is fairly fragile. We do not have great unit tests and in the case of conflicts, we need to read through the jj source code to try and figure out how it may be formatted.

To reduce the fragility, we should have integration tests which create a jj repo, and then run the commands we parse. The hope would be that this would more quickly notify us if output from a jj command changes.

Commands to parse:

  • jj files --no-pager
  • jj diff --summary --no-pager
  • jj resolve --list

In the case of jj resolve, we should ensure that we cover each conflict scenario i.e. 1, 2, 3 sided conflict; conflicts with deleted files; conflicts with renamed files.

@zschreur zschreur added the enhancement New feature or request label Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant