You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The way we parse jj's cli output is fairly fragile. We do not have great unit tests and in the case of conflicts, we need to read through the jj source code to try and figure out how it may be formatted.
To reduce the fragility, we should have integration tests which create a jj repo, and then run the commands we parse. The hope would be that this would more quickly notify us if output from a jj command changes.
Commands to parse:
jj files --no-pager
jj diff --summary --no-pager
jj resolve --list
In the case of jj resolve, we should ensure that we cover each conflict scenario i.e. 1, 2, 3 sided conflict; conflicts with deleted files; conflicts with renamed files.
The text was updated successfully, but these errors were encountered:
The way we parse jj's cli output is fairly fragile. We do not have great unit tests and in the case of conflicts, we need to read through the jj source code to try and figure out how it may be formatted.
To reduce the fragility, we should have integration tests which create a jj repo, and then run the commands we parse. The hope would be that this would more quickly notify us if output from a jj command changes.
Commands to parse:
jj files --no-pager
jj diff --summary --no-pager
jj resolve --list
In the case of
jj resolve
, we should ensure that we cover each conflict scenario i.e. 1, 2, 3 sided conflict; conflicts with deleted files; conflicts with renamed files.The text was updated successfully, but these errors were encountered: