Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Scrollback for joining users. #142

Open
zorchenhimer opened this issue Oct 24, 2020 · 4 comments
Open

Add Scrollback for joining users. #142

zorchenhimer opened this issue Oct 24, 2020 · 4 comments
Labels
enhancement New feature or request

Comments

@zorchenhimer
Copy link
Owner

Add a scrollback with the last N messages in chat to send to joining users. The number of messages should be configurable.

@zorchenhimer zorchenhimer added the enhancement New feature or request label Oct 24, 2020
@zorglube
Copy link
Contributor

zorglube commented May 12, 2021

Yep, seems to be an good idea.
Did you already though of a solution to keep the last N messages ?

  • Maybe an in ram rolling stack ?

@CptPie
Copy link

CptPie commented May 12, 2021

if i understand correctly a chat message is defined here:

type DataMessage struct {

Therefore it should be rather easy to implement a rolling stack with a fixed length to enable scrollback.

@zorglube
Copy link
Contributor

I bet the 'bigest' problem isn't the stack but handling the new chat user and send just to him the stack content.

@zorchenhimer
Copy link
Owner Author

Nah, that should be pretty straight forward. A bunch of (hidden) messages are already sent to the client during the join process. Sending the scrollback would just happen after all that. I suppose it could be a new hidden message type so it could be formatted differently or something (eg, greyed out), but that's not exactly necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants