Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some line endings can break modules. Should be tested for. #421

Open
timcdlucas opened this issue Apr 20, 2018 · 0 comments
Open

Some line endings can break modules. Should be tested for. #421

timcdlucas opened this issue Apr 20, 2018 · 0 comments

Comments

@timcdlucas
Copy link
Contributor

I don't know exactly what went wrong but this version of a module has some \r line endings that broke LoadModule.

https://github.com/zoonproject/modules/blob/c1bca5e8776f6967be488b932ff92ad63b66f70d/R/LonLatToCovariates.R

Discussed in PR zoonproject/modules#166

This particular instance fixed in zoonproject/modules#167 I hope.

But we should add a test in test_module for this once we've worked out exactly what is and isn't allowe.d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@timcdlucas