From 775ccb3f25abf04318e267c724413d2f817a30e8 Mon Sep 17 00:00:00 2001 From: Ori Kotek Date: Mon, 30 Oct 2023 20:14:25 +0200 Subject: [PATCH] Refactor _perform_commands function in github_app.py to improve command handling --- pr_agent/servers/github_app.py | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/pr_agent/servers/github_app.py b/pr_agent/servers/github_app.py index 2bb85a3d3..7b33fdc24 100644 --- a/pr_agent/servers/github_app.py +++ b/pr_agent/servers/github_app.py @@ -122,7 +122,7 @@ async def handle_request(body: Dict[str, Any], event: str): if body.get("requested_reviewer", {}).get("login", "") != bot_user: return {} get_logger().info(f"Performing review for {api_url=} because of {event=} and {action=}") - await _perform_commands(get_settings().github_app.pr_commands, agent, body, api_url, log_context) + await _perform_commands(agent, body, api_url, log_context) # handle pull_request event with synchronize action - "push trigger" for new commits elif event == 'pull_request' and action == 'synchronize' and get_settings().github_app.handle_push_trigger: @@ -174,7 +174,7 @@ async def handle_request(body: Dict[str, Any], event: str): get_logger().info(f"Skipping incremental review because there was no initial review for {api_url=} yet") return {} get_logger().info(f"Performing incremental review for {api_url=} because of {event=} and {action=}") - await _perform_commands(get_settings().github_app.push_commands, agent, body, api_url, log_context) + await _perform_commands(agent, body, api_url, log_context) finally: # release the waiting task block @@ -203,8 +203,9 @@ def _check_pull_request_event(action: str, body: dict, log_context: dict, bot_us return pull_request, api_url -async def _perform_commands(commands: List[str], agent: PRAgent, body: dict, api_url: str, log_context: dict): +async def _perform_commands(agent: PRAgent, body: dict, api_url: str, log_context: dict): apply_repo_settings(api_url) + commands = get_settings().github_app.pr_commands for command in commands: split_command = command.split(" ") command = split_command[0]