-
-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lua_resty_session > v4.0.0 doesnt work #480
Comments
update: |
this has been released, it is the version that became 1.7.6-3 , it just looks as if there was no corresponding git tag. It is quite possible Kong won't work with lua-resty-session < 4 anymore. There is #478 that I haven't found time to review, yet. |
sorry for my ignorance, if both 3.10 and >4 are installed at the same time, does the >4 module get used for everything? If I (to test only) force remove v4 from my docker container, my problem is fixed, but as kong specifies it required >4, I cannot guarantee another area is broken. This would imply that the newer version is being used, even if a module specifies an older one in its rockspec file |
I'm not really an expert when it comes to Lua packaging, but I don't believe there is a way to support multiple versions of the same library at the same time. The modules would need to have different names for this to work IIUC. And I honestly don't know which one would win if two versions are around. |
That seems to be the conclusion my research has lead to too. |
THANK YOU SO MUCH ... I use https://github.com/Kong/kong (3.4.2) and I resolved the error using this command inside my custom kong image (to resolve lua_resty_session duplication
|
However the potential side effect on Kong itself is kinda scary :) |
closes #464 #480 #503; thanks @oldium @balajiv113 Signed-off-by: Hans Zandbelt <[email protected]>
This is based upon www/lua-resty-session (v4), but is needed for lua-resty-openidc. The version 3.x is pinned in the lua-resty-openidc dependencies: https://github.com/zmartzone/lua-resty-openidc/blob/9f3a4fcade930f6f38ee0cb43cabf50cebffbcc9/lua-resty-openidc-1.7.6-3.rockspec#L27 There is apparently currently no clear plan on when/if lua-resty-openidc will be updated to include changes for lua-resty-session 4.X, see discussions on zmartzone/lua-resty-openidc#480 Additionally to what the author submitted some changes by me: - add conflicts with www/lua-resty-session - give up maintainership of www/lua-resty-session PR: 281142
There is apparently currently no clear plan on when/if lua-resty-openidc will be updated to include changes for lua-resty-session 4.X, see discussions on zmartzone/lua-resty-openidc#480 Additionally: - give up maintainership PR: 281143, 281142, 281079
https://github.com/zmartzone/lua-resty-openidc/blob/v1.7.6/lib/resty/openidc.lua#L1482
lua_resty_session > v4.0.0 removed "present" from the item returned from "session.start()"
This causes this to always fail
lua-resty-openidc/lib/resty/openidc.lua
Line 1483 in 5a7b9e2
Im using the https://github.com/revomatico/kong-oidc/tree/master plugin for kong and could not get it to work. Im new to lua, but was able to work my way through it and found that the v4.0.0 upgrade to the session library caused the break
The text was updated successfully, but these errors were encountered: