Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please bump the Golang version to a modern one #440

Closed
yurivict opened this issue May 23, 2024 · 6 comments
Closed

Please bump the Golang version to a modern one #440

yurivict opened this issue May 23, 2024 · 6 comments

Comments

@yurivict
Copy link

here

Errors:

# golang.org/x/sys/unix
vendor/golang.org/x/sys/unix/syscall.go:82:16: unsafe.Slice requires go1.17 or later (-lang was set to go1.16; check go.mod)
vendor/golang.org/x/sys/unix/syscall_bsd.go:247:20: unsafe.Slice requires go1.17 or later (-lang was set to go1.16; check go.mod)
vendor/golang.org/x/sys/unix/syscall_unix.go:117:7: unsafe.Slice requires go1.17 or later (-lang was set to go1.16; check go.mod)
@developStorm
Copy link
Member

@phillip-stephens thoughts?

@phillip-stephens
Copy link
Contributor

Yeah we should def do this. I started it here, but something is going wrong in the integration tests. I need to take some time and figure out how these integration tests are working to know what I broke. 😭

@mzpqnxow
Copy link
Contributor

mzpqnxow commented Aug 4, 2024

Yeah we should def do this. I started it here, but something is going wrong in the integration tests. I need to take some time and figure out how these integration tests are working to know what I broke. 😭

Do these tests pass with the current master, without changes? I vaguely recall there being some issues with CI though I don't recall of they were specifically related to validation of the output against the schemas

Something to check, before you bang your head too much against the wall 😊

@Seanstoppable
Copy link
Contributor

@phillip-stephens I just realized I did a similar thing as you in #461, but integration tests pass just fine there. Looking at your own PR, it looks pretty much all the containers failed on crypto related items (you'll see errors in docker container execution). Since you didn't change any of them, perhaps a failure stemming from whatever was running the integration tests, rather than an issue with the change itself?

@mzpqnxow
Copy link
Contributor

mzpqnxow commented Aug 23, 2024

I added a note to the test failure, in case it saves you a few minutes in identifying where the actual ERROR is

Seems like a NULL value is not being serialized/deserialized from a dict into the expected custom int class

@phillip-stephens
Copy link
Contributor

Closed with #461. Thanks @Seanstoppable !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants