Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use dep: syntax for dependencies in features. #394

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

waywardmonkeys
Copy link
Contributor

This prevents creating implicit features for them which can be confusing (and duplicates features).

@waywardmonkeys
Copy link
Contributor Author

This drastically improves what is shown when using cargo add.

Before:

❯ cargo init && cargo add miette
    Creating binary (application) package
note: see more `Cargo.toml` keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html
    Updating crates.io index
      Adding miette v7.2.0 to dependencies
             Features:
             + derive
             + miette-derive
             - backtrace
             - backtrace-ext
             - fancy
             - fancy-base
             - fancy-no-backtrace
             - fancy-no-syscall
             - no-format-args-capture
             - owo-colors
             - serde
             - supports-color
             - supports-hyperlinks
             - supports-unicode
             - syntect
             - syntect-highlighter
             - terminal_size
             - textwrap
    Updating crates.io index
     Locking 11 packages to latest compatible versions

After:

❯ cargo init && cargo add miette --path ../miette
    Creating binary (application) package
note: see more `Cargo.toml` keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html
      Adding miette (local) to dependencies
             Features:
             + derive
             - fancy
             - fancy-base
             - fancy-no-backtrace
             - fancy-no-syscall
             - no-format-args-capture
             - serde
             - syntect-highlighter
    Updating crates.io index
     Locking 11 packages to latest compatible versions

This prevents creating implicit features for them which can be
confusing (and duplicates features).
@waywardmonkeys
Copy link
Contributor Author

@zkat Hello, just wondering if you could please take a look at this PR and the other couple that I have open?

@zkat zkat merged commit 789a04e into zkat:main Sep 25, 2024
15 checks passed
@waywardmonkeys waywardmonkeys deleted the use-dep-syntax branch September 25, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants