Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try with more passports and improve reading #73

Open
0xturboblitz opened this issue Mar 5, 2024 · 13 comments
Open

Try with more passports and improve reading #73

0xturboblitz opened this issue Mar 5, 2024 · 13 comments
Labels
easy help wanted Extra attention is needed ODHack

Comments

@0xturboblitz
Copy link
Member

0xturboblitz commented Mar 5, 2024

The libraries we use for NFC reading work well in some cases but sometimes fail. One example of error I had recently with a passport on iOS is the following:

2024-03-04 21:39:27.2100 - Starting Password Authenticated Connection Establishment (PACE)
2024-03-04 21:39:27.2100 - Performing PACE with id-PACE-DH-GM-3DES-CBC-CBC
2024-03-04 21:39:38.2310 - PACE Failed - falling back to BAC
2024-03-04 21:39:38.2620 - Error reading tag: sw1 - 0x68, sw2 - 0x83
2024-03-04 21:39:38.2630 - reason: Last command of the chain expected

Trying with new passports and solving those bugs would really help. As with other issues, we will reward generously anyone helping on that, just DM us.

Android

Main libs are:
https://github.com/tananaev/passport-reader
https://github.com/jllarraz/AndroidPassportReader

We use the first for nfc and the second for OCR. The second also has nfc, might wanna look how it differs.

Rarimo here

iOS

We use:
https://github.com/AndyQ/NFCPassportReader

For OCR I sometimes get the wrong 3 inputs

@0xturboblitz 0xturboblitz added help wanted Extra attention is needed good first issue Good for newcomers easy labels Mar 5, 2024
@princeibs
Copy link

Hi @0xturboblitz, this seems like an interesting fix. I would like to jump on it

@0xturboblitz
Copy link
Member Author

please go ahead!

@princeibs
Copy link

Hi @0xturboblitz, I wanted to DM you concerning some assistance I need for this project, but i realised that your telegram handle is not in your OnlyDust profile. Please can you help me with other means I can reach out?

@0xturboblitz
Copy link
Member Author

You can DM me at @FlorentTavernier on telegram

@danielcdz
Copy link

Hello! @0xturboblitz, I would like to help with this one!

@Adecom16
Copy link

Hi @0xturboblitz i would love to work on this, can i ??

@0xturboblitz
Copy link
Member Author

Please explain how you would tackle it first!

@Adecom16
Copy link

Adecom16 commented May 23, 2024

Please explain how you would tackle it first!

I am Adeoluwa a smart contract developer. The possible solution to tackle this is:

  • Carefully audit the software implementation of the communication protocols (PACE, BAC) to ensure compliance with relevant
    specifications (e.g., ICAO Doc 9303).

  • Checking any software updates or patches that may address known issues or vulnerabilities.

  • Investigating potential interference from other electronic devices or environmental factors that may disrupt the NFC communication.

  • Try reading the passport in a different location or controlled environment.

@danielcdz
Copy link

danielcdz commented May 23, 2024

Please explain how you would tackle it first!

I will tackle this by:

  • Testing with iOS devices and checking OS versions to discard issues caused by the device.
  • Focus on iOS issues related to NFC communication libraries, and check for non-braking changes and updates that may help fix the issues.
  • Test with passports in a controlled environment, the error can be caused by an uncontrolled environment and disruption from other devices.
  • Handle errors in a user-friendly way to send better logs for helping debugging in the future.

@RJMadrigal
Copy link

Hi! I would like to help with this issue.

@remicolin remicolin removed the good first issue Good for newcomers label Jul 26, 2024
@LazarusAA
Copy link

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

Hi @0xturboblitz, I'm a software developer interested in gaining experience with projects like this. This seems like a fun issue to tackle, and I feel confident I can find the cause of this bugs and fix them.

How I plan on tackling this issue

I would start off by testing different passports to familiarize with the errors and get an idea of what might be the issue. Then Id tackle them one by one making sure that everything works as it should.

I would appreciate the opportunity.

@CrimsonKarma44
Copy link

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

I have 3 years of experience in backend programming in golang and python framework (django, flask)

How I plan on tackling this issue

i will test the service with multiple passports to help with accuracy of the reading

@Damilola145
Copy link

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

Hi,I'm a software developer with 3 years of experience.I have a desire to always make software solutiions available when the need arises.

How I plan on tackling this issue

I would examine with different passports and observe the test,and implement the best solutions based from the results drawn from the test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy help wanted Extra attention is needed ODHack
Projects
None yet
Development

No branches or pull requests

9 participants