You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I just encountered a bug when trying for the first time to use the OpenPassportQRcode components.
(Quickly solved thanks to direct support from @remicolin ).
This issue is just to capture/discuss a potential improvement on the typing of the userId component prop.
@sripwoud thanks for opening the issue. UUID and hexifiable strings are indeed the only type supported for now (with hexifiable strings).
I just raised #187 that fix the issue, a new version of the sdk is already available, we still need to push a new version of the app to the store to parse the string userId in the inputs of the circuit correctly.
Please note that max length of the userId for type string is capped by the use of BN254, i wrote more details about it here
I just encountered a bug when trying for the first time to use the
OpenPassportQRcode
components.(Quickly solved thanks to direct support from @remicolin ).
This issue is just to capture/discuss a potential improvement on the typing of the
userId
component prop.openpassport/sdk/src/QRcode/OpenPassportQRcode.d.ts
Line 6 in 7aba22e
Remi explained me that it can't actually be any string. but only hexifiable strings, so that it can be used as a signal for the circuit.
It would be nice to have either a runtime check/validation or a better TS type to avoid that devs naively put any string.
Eg the type of UUID?
E.g I had used my username at first. It resulted in a error:
reference Error: document is undefined
The text was updated successfully, but these errors were encountered: