Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for rack 3.1.0 #548

Open
TeamNautilus opened this issue Jul 29, 2024 · 3 comments
Open

Support for rack 3.1.0 #548

TeamNautilus opened this issue Jul 29, 2024 · 3 comments

Comments

@TeamNautilus
Copy link

Hello Zipmark,

we are Team Nautilus, and we would like to report an issue related to the rspec_api_documentation gem.

We are using Ruby 3.1.1 with the following Gemfile:

gem 'rails', '7.1.3'
gem 'rack', '3.0.11'
gem 'rspec_api_documentation', git: 'https://github.com/zipmark/rspec_api_documentation.git'

GIT
  remote: https://github.com/zipmark/rspec_api_documentation.git
  revision: d32bf17932a379052e8bb7540fc29ce7e72712ae
  specs:
    rspec_api_documentation (6.1.0)

and when we run the command rake docs:generate, everything works fine.

However, after updating the rack gem to version 3.1.0, we encounter the following error:

NoMethodError: 
    undefined method 'rewind' for nil:NilClass
        input.rewind

at rspec_api_documentation-d32bf17932a3/lib/rspec_api_documentation/client_base.rb#48.

Can you help us resolve this issue?

Thank you.

@johanvdlaak
Copy link

I'm running into this as well with rspec_api_documentation 6.1.0, ruby 3.2.5, rails 7.1.3.4 and rack 3.1.7.

@ERCubed
Copy link

ERCubed commented Aug 26, 2024

In rack 3.0.11 last_request.env["rack.input"] has a value. After that it does not.

https://github.com/rack/rack/blob/main/UPGRADE-GUIDE.md#rackinput-is-no-longer-required-to-be-rewindable

Switching forks fixed the problem:
gem 'rspec_api_documentation', github: 'SchoolKeep/rspec_api_documentation', ref: '13df1ac'

@TeamNautilus
Copy link
Author

TeamNautilus commented Aug 28, 2024

Switching forks fixed the problem: gem 'rspec_api_documentation', github: 'SchoolKeep/rspec_api_documentation', ref: '13df1ac'

It works also for us, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants