Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all table size config for new adapters #629

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

puddly
Copy link
Contributor

@puddly puddly commented Jun 13, 2024

I believe all of the config affecting table sizes no longer works with newer versions of EmberZNet. The source route table size, for example, is a compile-time constant that generates an array of that size in memory. There doesn't appear to be a way to grow or shrink it.

The specific EZSP version where these config options start taking effect needs to be determined, as right now we apply it for all adapters supporting EZSPv7 and above.

Copy link

codecov bot commented Jun 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.15%. Comparing base (91b8f37) to head (59ff4d3).

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #629   +/-   ##
=======================================
  Coverage   99.15%   99.15%           
=======================================
  Files          50       50           
  Lines        3412     3415    +3     
=======================================
+ Hits         3383     3386    +3     
  Misses         29       29           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant