Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Password Encryption Strategy #30

Open
1 task
zhorton34 opened this issue Apr 24, 2020 · 0 comments
Open
1 task

Password Encryption Strategy #30

zhorton34 opened this issue Apr 24, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@zhorton34
Copy link
Owner

zhorton34 commented Apr 24, 2020

  • Update Password Encryption Strategy

Currently we are storing sha1 hash of the password.
Then, on login, we are comparing the hash of the submitted password with the database column.

This isn't a good idea because unsalted hashes are vulnerable to rainbow tables, and sha1 is not a good choice because it's a fast hash.

PHP has good built-in functions that handle this securely, here is some info:

https://phptherightway.com/#password_hashing https://paragonie.com/blog/2017/12/2018-guide-building-secure-php-software#secure-php-passwords

@zhorton34 zhorton34 added the enhancement New feature or request label Apr 24, 2020
@zhorton34 zhorton34 changed the title Password Encryption Stradegy Password Encryption Strategy Apr 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant