Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] - waveform is not uploaded in the spectroscopy mode #45

Closed
1 of 2 tasks
YuanG13 opened this issue Jun 28, 2023 · 3 comments
Closed
1 of 2 tasks

[BUG] - waveform is not uploaded in the spectroscopy mode #45

YuanG13 opened this issue Jun 28, 2023 · 3 comments
Labels
bug Something isn't working fix commited fix / enhancment will be deployed in the next release jira Sync the issue to ZI LabOneQ internal issue tracker.

Comments

@YuanG13
Copy link

YuanG13 commented Jun 28, 2023

Describe the bug
In pulsed resonator spectroscopy experiment,

if there are more than one logical measure signals(for example: measure0, measure1, measure2) in a physical port, and you define a LaboneQ Experiment with experimental signals of all the lines, and define a pulsed resonator spectroscopy experiment on the measure signal which is not the first one(for example measure1 or measure2).

then, the waveform of the measure pulse is not uploaded to the device, and the experiment is become a CW resonator spectroscopy.

To Reproduce
see the experiment, device setup, compiled experiment json files for detail.
issue.zip

Expected behavior
A pulsed resonator spectroscopy experiment.

Solution
****** Please check wether this solution influences other part of the compiler*******
change codes in laboneq.controller.devices.device_zi.py line 818 to 821:

idx = 0
while idx in waves_by_index:
    bin_waves.append(waves_by_index[idx])
    idx += 1

to

for _ , wave in waves_by_index.items():
    bin_waves.append(wave)

Versions used:

  • laboneq == 2.4
  • zhinst-core
  • others

Context

  • Do you know a workaround for the issue? If yes, please provide a short description.
  • Does the issue block your experiments?
@QuantumClemens QuantumClemens added bug Something isn't working jira Sync the issue to ZI LabOneQ internal issue tracker. labels Jun 28, 2023
@YuanG13
Copy link
Author

YuanG13 commented Jun 30, 2023

this issue also happens with integration mode. the waveform signal is also not uploaded properly, and the fix I provided doesn't fixed in integration mode. I would assume this is because that the integration weight is also not properly uploaded.

@QuantumClemens
Copy link
Collaborator

@YuanG13 thanks for the additional info, we are looking into this issue

@QuantumClemens QuantumClemens added the fix commited fix / enhancment will be deployed in the next release label Jul 5, 2023
@QuantumClemens
Copy link
Collaborator

@YuanG13 This should be fixed since 2.10, closing the ticket - let us know if you observe additional issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fix commited fix / enhancment will be deployed in the next release jira Sync the issue to ZI LabOneQ internal issue tracker.
Projects
None yet
Development

No branches or pull requests

2 participants