From 7324bef1e16c623d76f307dc2b84f8d460e6c63e Mon Sep 17 00:00:00 2001 From: zhangstar333 <2561612514@qq.com> Date: Tue, 19 Sep 2023 14:33:52 +0800 Subject: [PATCH] update review --- .../distinct_streaming_aggregation_sink_operator.cpp | 10 ++-------- .../distinct_streaming_aggregation_sink_operator.h | 3 +-- .../distinct_streaming_aggregation_source_operator.h | 2 +- 3 files changed, 4 insertions(+), 11 deletions(-) diff --git a/be/src/pipeline/exec/distinct_streaming_aggregation_sink_operator.cpp b/be/src/pipeline/exec/distinct_streaming_aggregation_sink_operator.cpp index 1616cab1120ca24..133a1448599d274 100644 --- a/be/src/pipeline/exec/distinct_streaming_aggregation_sink_operator.cpp +++ b/be/src/pipeline/exec/distinct_streaming_aggregation_sink_operator.cpp @@ -97,14 +97,8 @@ OperatorPtr DistinctStreamingAggSinkOperatorBuilder::build_operator() { DistinctStreamingAggSinkLocalState::DistinctStreamingAggSinkLocalState( DataSinkOperatorXBase* parent, RuntimeState* state) - : AggSinkLocalState(parent, state) { - dummy_mapped_data = std::make_shared('A'); -} - -Status DistinctStreamingAggSinkLocalState::init(RuntimeState* state, LocalSinkStateInfo& info) { - RETURN_IF_ERROR(Base::init(state, info)); - return Status::OK(); -} + : AggSinkLocalState(parent, state), + dummy_mapped_data(std::make_shared('A')) {} Status DistinctStreamingAggSinkLocalState::_distinct_pre_agg_with_serialized_key( doris::vectorized::Block* in_block, doris::vectorized::Block* out_block) { diff --git a/be/src/pipeline/exec/distinct_streaming_aggregation_sink_operator.h b/be/src/pipeline/exec/distinct_streaming_aggregation_sink_operator.h index c2bd6cd7a9aae9f..d0cb9abe4eea027 100644 --- a/be/src/pipeline/exec/distinct_streaming_aggregation_sink_operator.h +++ b/be/src/pipeline/exec/distinct_streaming_aggregation_sink_operator.h @@ -84,7 +84,6 @@ class DistinctStreamingAggSinkLocalState final ENABLE_FACTORY_CREATOR(DistinctStreamingAggSinkLocalState); DistinctStreamingAggSinkLocalState(DataSinkOperatorXBase* parent, RuntimeState* state); - Status init(RuntimeState* state, LocalSinkStateInfo& info) override; Status close(RuntimeState* state) override; Status _distinct_pre_agg_with_serialized_key(vectorized::Block* in_block, vectorized::Block* out_block); @@ -114,4 +113,4 @@ class DistinctStreamingAggSinkOperatorX final }; } // namespace pipeline -} // namespace doris \ No newline at end of file +} // namespace doris diff --git a/be/src/pipeline/exec/distinct_streaming_aggregation_source_operator.h b/be/src/pipeline/exec/distinct_streaming_aggregation_source_operator.h index ad66a6d93c6bbe6..78edf4815fd80a3 100644 --- a/be/src/pipeline/exec/distinct_streaming_aggregation_source_operator.h +++ b/be/src/pipeline/exec/distinct_streaming_aggregation_source_operator.h @@ -79,4 +79,4 @@ class DistinctStreamingAggSourceOperatorX final : public AggSourceOperatorX { }; } // namespace pipeline -} // namespace doris \ No newline at end of file +} // namespace doris