feat: enable unsigned transactions in tracing #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
lumtis
reviewed
May 29, 2024
kingpinXD
reviewed
May 31, 2024
Comment on lines
+33
to
+34
| AttributeKeyTxNonce = "txNonce" | ||
| AttributeKeyTxData = "txData" |
There was a problem hiding this comment.
these are new attributes for events for synthetic txs emitted in node code and parsed in rpc methods
kingpinXD
approved these changes
May 31, 2024
lumtis
approved these changes
May 31, 2024
skosito
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of transactions are applied directly (fungible module). They don't have a signature, and tracing those txs fails with signature error. This fix is checking for unsigned txs and is not using it to parse
fromfield.