Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove duplicate events logs #112

Merged
merged 5 commits into from
Sep 9, 2024
Merged

remove duplicate events logs #112

merged 5 commits into from
Sep 9, 2024

Conversation

skosito
Copy link
Contributor

@skosito skosito commented Sep 9, 2024

reference: crypto-org-chain/ethermint#405

Summary by CodeRabbit

  • Improvements
    • Updated the changelog to document the avoidance of duplicate cache events emitted from EVM hooks.
  • Changes
    • Modified transaction processing to eliminate automatic event emissions, leading to a quieter transaction handling mechanism.

Copy link

coderabbitai bot commented Sep 9, 2024

Walkthrough

Walkthrough

The pull request introduces changes to the CHANGELOG.md and the x/evm/keeper/state_transition.go file. It adds a note in the changelog regarding the avoidance of duplicate cache events emitted from EVM hooks, referencing pull request #112. Additionally, the ApplyTransaction method in the Keeper struct is modified by removing the line that emits events through the context's event manager, indicating a change in how transaction outcomes are communicated.

Changes

File Change Summary
CHANGELOG.md Added entry noting the avoidance of duplicate cache events emitted from EVM hooks (PR #112).
x/evm/keeper/state_transition.go Removed event emission line in ApplyTransaction method, altering transaction outcome communication.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant EVM
    participant EventManager

    User->>EVM: Submit Transaction
    EVM->>EVM: Process Transaction
    EVM-->>User: Transaction Result
    Note right of EVM: No event emitted
Loading

Tip

New review model

We have updated our review workflow to use the Anthropic's Claude family of models. Please share any feedback in the discussion post on our Discord.


New features

Walkthrough comment now includes:

  • Possibly related PRs: A list of potentially related PRs to help you recall past context.
  • Suggested labels: CodeRabbit can now suggest labels by learning from your past PRs. You can also provide custom labeling instructions in the UI or configuration file.

Notes:

  • Please share any feedback in the discussion post on our Discord.
  • Possibly related PRs, automatic label suggestions based on past PRs, learnings, and possibly related issues require data opt-in (enabled by default).

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@brewmaster012 brewmaster012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 04c6abd and 9cd2340.

Files selected for processing (2)
  • CHANGELOG.md (1 hunks)
  • x/evm/keeper/state_transition.go (1 hunks)
Files skipped from review due to trivial changes (1)
  • CHANGELOG.md

Copy link
Member

@lumtis lumtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@skosito skosito merged commit 2fad916 into main Sep 9, 2024
27 of 28 checks passed
@skosito skosito deleted the test-fixes branch September 9, 2024 23:47
@skosito skosito mentioned this pull request Sep 9, 2024
5 tasks
skosito added a commit that referenced this pull request Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants