-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
postrelease question: what if master branch is protected by a hook? #325
Comments
I also have some repositories where the master branch is protected. But I've allowed repository admins to push anyway. I don't know how to do it otherwise. You'd have to make the release + tag on a branch and then merge it into master after you've already uploaded something to pypi, for instance? Sounds a bit weird. Ideas welcome of course :-) |
Protected master branch makes sense of course. In my case it would have been nice if |
I'm afraid we'd have to push something in order to discover if we're allowed to push :) The best we can do seems to be to detect the github log message and print a line pointing at a (to be written) section in the documentation. Do you see other alternatives? @mauritsvanrees? |
I see. An other idea would be to let the user choose in postrelease to push the versionbump/changenote updates directly to master or to a new branch (with a sane branchname suggestion like |
I suspect you need to make the choice in the prerelease, already. Otherwise you're making changes on your local master branch that you can't push and have to clean up later. We could add a setting in But with a "do it on a branch" setting, also the people that can push to master (because they're admins) are forced to do it on a branch. Or the setting should be "ask if you want to do it on a branch". Pfffffff.... this is not a problem for which there is an easy and simple solution, I'm afraid. Personally, I'd feel most happy with the "just make the few people that can make a release an admin" solution. Those people also already have pypi access. But I can't oversee all the consequences and effects on a project's organisation. In this case, it seems to be Plone+addons. Can you and @mauritsvanrees come up with a solution? Maurits knows the details about access rights and releases within plone. An intermediary solution would be to start a branch yourself, by hand, and run "fullrelease" in there. A setting to warn you "hey, this is a protected project, don't you want to do it on a branch?" could help here. But what would be the default? I guess plone releasers sometimes use the Anyway.... more thinkwork needed :-) |
Thank you for your feedback on this. Much appreciated. And it's indeed a plone-addon-ish problem because in my case I have pypi access for the package but no admin rights on the repo. Thinking further ... this shouldn't happen in my oppinion and has to be communicated by the plone community what's exactly needed for a person who should be able to do a release... so I'd close this thread here and tend to a non-technical solution by defining the release workflow on plone and/or addon repos (namely pypi access and repo admin rights) ... maybe there's a plone releaseteam member willing to document this anywhere (or it's already done and I haven't found it?) @mauritsvanrees ? |
On zest.releaser's side, there is one question left, then: should we search for the word |
In PR #430 I added a bit of documentation that at least mentions the "protected branch" problem. |
I've just came across this here:
postrelease cannot push changes to repository if it's protected by a hook ... what can one do in that case?
The text was updated successfully, but these errors were encountered: