Passkey plugin - toPasskeyValidator - Allow for custom authenticator
#158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hjornigur Hey sorry for the late reply. In the meantime, our passkey plugins have undergone significant refactoring. Could you please make a new commit based on the updated codebase? Thanks in advance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces additional optional parameter to the
toPasskeyValidatorfunction -signWithAuthenticator, which followssimplewebauthn'sstartAuthenticationfunction signature.This will allow to use custom authentication functions, for example mobile ones, since
simplewebauthnsimply does not work on mobile devices natively :)