Drivers: Fuel_Gauge: MAX17048: added units to fuel_gauge sample output and Output of voltage is now shown in microVolts #75563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
previous code stored voltage value in millivolts, made changes to max17048 to store the value in microvolts.
sample was missing units of outputs ( time to discharge, charge, voltage), added units.
zephyrbot
added
area: Samples
zephyrbot
requested review from
aaronemassey,
galak,
kartben,
MaureenHelm,
microbuilder,
nashif and
teburd
Goyalrahul1516
changed the title
kartben
requested changes
Jul 8, 2024
There was a problem hiding this comment.
@Goyalrahul1516 can you please also look into the compliance issues? Thanks much for the PR!
Co-authored-by: Benjamin Cabé <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
previously sample output was without any units
The voltage parameter was supposed to give output in microvolts
actual output was in millivolts
made changes to provide output in microvolts.