Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drivers: serial: uart_cdns: fix interrupt driven for shell #75191

Closed
frankshuweilin opened this issue Jun 28, 2024 · 1 comment · Fixed by #75185
Closed

drivers: serial: uart_cdns: fix interrupt driven for shell #75191

frankshuweilin opened this issue Jun 28, 2024 · 1 comment · Fixed by #75185
Assignees
Labels
area: UART Universal Asynchronous Receiver-Transmitter bug The issue is a bug, or the PR is fixing a bug priority: medium Medium impact/importance bug
Milestone

Comments

@frankshuweilin
Copy link
Contributor

Describe the bug
With Cadence UART (driver: uart_cdns.c) as the shell backend, if both CONFIG_UART_INTERRUPT_DRIVEN and CONFIG_SHELL_BACKEND_SERIAL_INTERRUPT_DRIVEN are enabled, the console does not response properly. You will get unexpected echos when you type in commands.

The target platform is our proprietary with Cadence UART IP in it. The Zephyr version is 3.4.0.

To Reproduce
In prj.conf file, set
CONFIG_SHELL=y
CONFIG_SHELL_BACKENDS=y
CONFIG_SHELL_BACKEND_SERIAL=y
CONFIG_SHELL_BACKEND_SERIAL_INTERRUPT_DRIVEN=y
CONFIG_CONSOLE=y
CONFIG_UART_INTERRUPT_DRIVEN=y
CONFIG_UART_CONSOLE=y

Expected behavior
When typing in commands in UART terminal, proper echos should be seen

Impact
Not able to use CONFIG_SHELL_BACKEND_SERIAL_INTERRUPT_DRIVEN=y

Logs and console output
N/A

Environment (please complete the following information):

  • OS: Fedora 38
  • gtkterm
@frankshuweilin frankshuweilin added the bug The issue is a bug, or the PR is fixing a bug label Jun 28, 2024
Copy link

Hi @frankshuweilin! We appreciate you submitting your first issue for our open-source project. 🌟

Even though I'm a bot, I can assure you that the whole community is genuinely grateful for your time and effort. 🤖💙

@XenuIsWatching XenuIsWatching added this to the v3.7.0 milestone Jun 28, 2024
@XenuIsWatching XenuIsWatching linked a pull request Jun 28, 2024 that will close this issue
@henrikbrixandersen henrikbrixandersen added the area: UART Universal Asynchronous Receiver-Transmitter label Jun 29, 2024
@dcpleung dcpleung assigned frankshuweilin and unassigned dcpleung Jul 1, 2024
@nashif nashif added priority: low Low impact/importance bug priority: medium Medium impact/importance bug and removed priority: low Low impact/importance bug labels Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: UART Universal Asynchronous Receiver-Transmitter bug The issue is a bug, or the PR is fixing a bug priority: medium Medium impact/importance bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants