Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.x] feat!: have assert(Not)SeeIn() look in all matching node's text #141

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

kbond
Copy link
Member

@kbond kbond commented Jan 26, 2024

Given the following html:

<ul>
    <li>item 1</li>
    <li>item 2</li>
</ul>

Currently, this is the behaviour:

$browser->assertSeeIn('li', 'item1'); // pass as this is the first li in the dom
$browser->assertSeeIn('li', 'item2'); // fail

I think, in 2.x, the second should also pass.

tests/BrowserTests.php Outdated Show resolved Hide resolved
@kbond kbond changed the title minor: add test that should pass in 2.x [2.x] feat!: have assert(Not)SeeIn() look in all matching node's text Jan 26, 2024
@kbond kbond added this to the 2.0 milestone Jan 26, 2024
@kbond kbond changed the base branch from 1.x to 2.x February 21, 2024 15:44
@kbond kbond merged commit 93a3ab2 into zenstruck:2.x Feb 21, 2024
13 checks passed
@kbond kbond deleted the minor/assert-see-in-all branch February 21, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants