Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HttpOptions::withFiles(array $files) array shape is incorrect #153

Open
stetodd opened this issue Sep 10, 2024 · 1 comment
Open

HttpOptions::withFiles(array $files) array shape is incorrect #153

stetodd opened this issue Sep 10, 2024 · 1 comment

Comments

@stetodd
Copy link

stetodd commented Sep 10, 2024

The array shape for the $files argument to HttpOptions::withFiles(array $files) is defined as array<string, string>, but it should be array<string, UploadedFile>.

There is an existing issue (#97) suggesting strings should be allowed too, in which case it would become array<string, string|UploadedFile>.
@nikophil
Copy link
Member

nikophil commented Sep 13, 2024 •
edited
Loading

Hi @stetodd

indeed, you're right. Maybe you'd like to provide a PR for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stetodd @nikophil