Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InstallStream.getPackage() returns unimplemented #11

Open
zenhack opened this issue Apr 19, 2023 · 4 comments
Open

InstallStream.getPackage() returns unimplemented #11

zenhack opened this issue Apr 19, 2023 · 4 comments
Labels
bug Something isn't working

Comments

@zenhack
Copy link
Owner

zenhack commented Apr 19, 2023

Package installation via the UI works now, but the call to getPackage() is returning an unimplemented error for reasons I don't yet understand -- the method is indeed implemented on the server side, but print debugging reveals that the method is never actually being called. As a result, we get an error message and the package isn't added to our app list until we refresh the page.

@zenhack
Copy link
Owner Author

zenhack commented May 26, 2023

I'm hitting something similar with a call to viewsPuller.Sync. It's definitely implemented and definitely not being called. I'm starting to suspect a go-capnp bug (cc @lthibault)

@zenhack
Copy link
Owner Author

zenhack commented May 26, 2023

Note that in both of these cases we're calling the failing method on a promise, so that's probably important.

zenhack added a commit that referenced this issue May 26, 2023
zenhack added a commit that referenced this issue May 26, 2023
By inserting a strategic call to .Struct()
@zenhack
Copy link
Owner Author

zenhack commented May 26, 2023

I pushed a workaround for these, just waiting on the necessary promises. I'm going to keep this open though, since it's not a proper solution.

@zenhack
Copy link
Owner Author

zenhack commented May 26, 2023

I opened capnproto/go-capnp#521 to track the underlying issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant