Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doc improvement #554

Merged
merged 1 commit into from
Aug 21, 2023
Merged

Doc improvement #554

merged 1 commit into from
Aug 21, 2023

Conversation

ecoologic
Copy link
Contributor

A few things I noticed:

  • Better CBP readme
  • Correct comments for CBP methods
  • Instructions to merge public contributions

@ecoologic ecoologic requested a review from a team as a code owner August 21, 2023 01:05
Zendesk-NathanBellette
Zendesk-NathanBellette approved these changes Aug 21, 2023
View reviewed changes
Copy link
Contributor

@Zendesk-NathanBellette Zendesk-NathanBellette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ecoologic ecoologic merged commit bdb733b into master Aug 21, 2023
7 checks passed
@ecoologic ecoologic deleted the RED-1856-readme branch August 21, 2023 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fbvilela fbvilela fbvilela approved these changes

@Zendesk-NathanBellette Zendesk-NathanBellette Zendesk-NathanBellette approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ecoologic @fbvilela @Zendesk-NathanBellette