Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Too many threads, CPU use #28

Open
babbottscott opened this issue Apr 16, 2014 · 5 comments
Open

Too many threads, CPU use #28

babbottscott opened this issue Apr 16, 2014 · 5 comments

Comments

@babbottscott
Copy link

I seem to remember a configurable thread limit per ultragrep process. This appears to be no longer the case. cpu use is too high on logs servers with a thread per log file searched. There needs to be some cap.

@osheroff
Copy link
Contributor

maybe tricky to pull off given the architecture of a single C process per log file grepped. We could try rate limiting by forcing ug_guts to block writing to its pipe, but to do it "right" would probably mean a significant re-architecture, making ug_guts a multi-threaded process.

Nothing we could do with nice-levels?

@babbottscott
Copy link
Author

It's already renicing to +19. There was a suggestion to use taskset to add affinity to a subset of cpus. Perhaps that would be a cleaner implementation?

@osheroff
Copy link
Contributor

yeah, that could be fine. How many cpus need we reserve?

@babbottscott
Copy link
Author

First take I'd say 8 out of the 24 at most, but I'd love to see it configurable. Taskset takes strings like '1-4,6,8' for specifying affinity. If we could specify that string in the config, that would be great.

@briser
Copy link

briser commented Dec 7, 2016

dusts off thread Bump.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants