From b131fceaeb0cd784cccfe719e68822d4adf3d97c Mon Sep 17 00:00:00 2001
From: Thomas Neil James Shadwell <thomas@shadwell.im>
Date: Thu, 16 Nov 2023 16:32:02 -0800
Subject: [PATCH] Make it an error to use <a> tags without an exemption and
 correct wayward <a> tags.

Fixes #3911
Fixes #3992
---
 Global.d.ts                                   | 13 +++++++++++++
 project/zemn.me/next/components/Link/Link.tsx | 12 +++++++++++-
 project/zemn.me/next/pages/index.tsx          | 16 ++++++++--------
 3 files changed, 32 insertions(+), 9 deletions(-)

diff --git a/Global.d.ts b/Global.d.ts
index ae6be5a998..63aaa55018 100644
--- a/Global.d.ts
+++ b/Global.d.ts
@@ -24,3 +24,16 @@ declare module '*.jpg' {
 	export const blurWidth: number;
 	export const blurHeight: number;
 }
+
+type LinkBrand = 'hey. please use project/zemn.me/next/components/Link instead';
+
+declare module 'global' {
+	global {
+		namespace JSX {
+			interface IntrinsicElements {
+				// Override the `<a>` element
+				a: { 'data-brand': LinkBrand };
+			}
+		}
+	}
+}
diff --git a/project/zemn.me/next/components/Link/Link.tsx b/project/zemn.me/next/components/Link/Link.tsx
index a3879d7380..0495e06a60 100644
--- a/project/zemn.me/next/components/Link/Link.tsx
+++ b/project/zemn.me/next/components/Link/Link.tsx
@@ -54,6 +54,8 @@ function isFirstPartyURL(u: string | UrlObject | URL): boolean {
 	);
 }
 
+type Exempt<T> = T & { 'data-brand': LinkBrand };
+
 export function Link({ href, rel, target, ...props }: LinkProps) {
 	if (href !== undefined && !isFirstPartyURL(href)) {
 		rel = `${rel ?? ''} external`.trim();
@@ -62,7 +64,15 @@ export function Link({ href, rel, target, ...props }: LinkProps) {
 	// next Link has a strangely strident stance on providing the href parameter
 	// which we do not. if there is no href we just fall back to using an <a> tag.
 	// https://github.com/i18next/next-i18next/issues/599
-	if (href === undefined) return <a {...{ href, rel, target, ...props }} />;
+	if (href === undefined) {
+		const p = {
+			href,
+			rel,
+			target,
+			...props,
+		};
+		return <a {...(props as Exempt<typeof p>)} />;
+	}
 	return <NextLink {...{ href, rel, target, ...props }} />;
 }
 
diff --git a/project/zemn.me/next/pages/index.tsx b/project/zemn.me/next/pages/index.tsx
index db6dd3a128..6b57ec3ed1 100644
--- a/project/zemn.me/next/pages/index.tsx
+++ b/project/zemn.me/next/pages/index.tsx
@@ -145,19 +145,19 @@ export default function Main() {
 						<p>
 							The background video (“hero video”) is of a hidden
 							area in the gardens of{' '}
-							<a href="https://en.wikipedia.org/wiki/Kenwood_House">
+							<Link href="https://en.wikipedia.org/wiki/Kenwood_House">
 								Kenwood House
-							</a>
+							</Link>
 							, a beautiful stately home sandwiched between
 							Highgate and Hampstead in London where I grew up.
 							It's located at about{' '}
-							<a
+							<Link
 								href="https://goo.gl/maps/JEAzn2kZgu6pyaNA6"
 								rel="nofollow"
 								title="Location of the Kenwood video"
 							>
 								51.57139601074658°N, -0.16924392259112794°E
-							</a>
+							</Link>
 							.
 						</p>
 						<p>
@@ -171,9 +171,9 @@ export default function Main() {
 						<p>
 							The type and style itself was inspired by older,
 							pre-computer era typsetting such as the{' '}
-							<a href="https://assets.lloyds.com/assets/pdf-lloyds-acts-mar07lloydsact1871/1/pdf-lloyds-acts-Mar07LloydsAct1871.pdf">
+							<Link href="https://assets.lloyds.com/assets/pdf-lloyds-acts-mar07lloydsact1871/1/pdf-lloyds-acts-Mar07LloydsAct1871.pdf">
 								Lloyd's Act 1871
-							</a>
+							</Link>
 							. Particular effort was put into trying to have
 							content fill horizontal space automatically, as seen
 							in older documents that try to make the most of the
@@ -211,9 +211,9 @@ export default function Main() {
 						</p>
 						<p>
 							The eye logo is a reference to the well-known{' '}
-							<a href="https://en.wikipedia.org/wiki/Eye_of_Providence">
+							<Link href="https://en.wikipedia.org/wiki/Eye_of_Providence">
 								‘eye of providence’
-							</a>
+							</Link>
 							, a symbol that represents human achievement as
 							being incomplete without God. I wanted it to reflect
 							the idea that, in a universe that might not have a