Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Court] Fix double court pool iteration #1290

Closed
Chralt98 opened this issue Mar 20, 2024 · 1 comment
Closed

[Court] Fix double court pool iteration #1290

Chralt98 opened this issue Mar 20, 2024 · 1 comment

Comments

@Chralt98
Copy link
Member

#1285 (comment)

Future optimization to avoid iterating over all pools twice is to cache the total stake.

The iteration over the court pool happens twice here

However keep in mind that the inflation period check needs to hold true here

So caching the total stake might not allow us to do the inflation period check properly.

@Chralt98 Chralt98 changed the title [Court] Double court pool iteration fix [Court] Fix double court pool iteration Mar 20, 2024
@Chralt98
Copy link
Member Author

Chralt98 commented May 8, 2024

This is a small performance optimization that would only be relevant if we had major and significant performance problems because of it. Because we currently have no significant user traction that notices this performance issue, I decide to close this issue.

@Chralt98 Chralt98 closed this as completed May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant