Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Asset-Router] Detect unsupported assets at compile time #1198

Open
sea212 opened this issue Dec 1, 2023 · 0 comments
Open

[Asset-Router] Detect unsupported assets at compile time #1198

sea212 opened this issue Dec 1, 2023 · 0 comments
Labels
l:M Solving the issue takes days p:low Low priority, resolution of this issue can wait t:enhancement The issue described an enhancement

Comments

@sea212
Copy link
Member

sea212 commented Dec 1, 2023

The goal of this issue is to improve the asset-router, such that trying to reserve or lock unsupported assets will result in a compilation error.

Currently the asset-router does check whether an asset supports reserves and locks during execution. This is a bad practice, as pallet which utilize the asset-router pallet don't know if the assets they are planning to reserve or lock support it at all.
@sea212 sea212 added p:low Low priority, resolution of this issue can wait t:enhancement The issue described an enhancement l:M Solving the issue takes days labels Dec 1, 2023
@sea212 sea212 mentioned this issue Dec 1, 2023
Merged
@sea212 sea212 changed the title Move asset-router's logic support detection to compile-time [Asset-Router] Detect unsupported assets at compile time Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
l:M Solving the issue takes days p:low Low priority, resolution of this issue can wait t:enhancement The issue described an enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sea212