Extract fee event TransactionFeePaid
from transaction-payment
#493
Labels
enhancement
New feature or request
TransactionFeePaid
from transaction-payment
#493
Currently I assume that transaction fees are stated for the
Withdraw
inhistoricalAccountBalances
event. Is this correct?It would be cool to be more precise for what the withdraw actually was used. But I think it is okay how it is now, because the
transaction-payment
pallet does not emit an event directly here (only indirectly over withdraw and deposit (for a refund)). However there is indeed an event calledTransactionFeePaid
in the transaction payment pallet. But leave this for now,Withdraw
events are sufficient for me to recognise transaction fees.But we need to take a look at how
pallet-asset-tx-payment
handles this. It emits a different eventAssetTxFeePaid
, but does it also emit anWithdraw
event?We implement our own
OnChargeAssetTransaction
here. This means we callorml_tokens
here, which ultimately means that we need to catch the events of orml-tokensWithdrawn
andDeposited
to have an equivalent to the pallet pallet-transaction-payment.Or we go the other route to index the
AssetTxFeePaid
event and theTransactionFeePaid
properly.As a result of adding the
AssetTxFeePaid
andTransactionFeePaid
events, theWithdraw
,Deposit
,Withdrawn
andDeposited
events are basically a double booking of fees then.What would you suggest?
The text was updated successfully, but these errors were encountered: