Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Search] Pressing "enter" in the search box wipes out input #3

Open
2 tasks done
zeh opened this issue Aug 8, 2023 · 1 comment
Open
2 tasks done

[Search] Pressing "enter" in the search box wipes out input #3

zeh opened this issue Aug 8, 2023 · 1 comment
Assignees
@zeh
Labels
bug Something isn't working
Milestone
Beta

Comments

@zeh
Copy link
Owner

zeh commented Aug 8, 2023 •
edited
Loading

If we enter a word in search, and press "ENTER", it simply empties the search field. We need better logic there.

Requirements

  • When pressing "ENTER", it needs to select the first available option, or otherwise do nothing
  • Check on mobile to see what the action/submit software keyboard button is doing (should do the same)
@zeh zeh self-assigned this Aug 8, 2023
@zeh zeh added this to the Beta milestone Aug 8, 2023
@zeh zeh added the bug Something isn't working label Aug 8, 2023
@zeh zeh changed the title [Search][Bug] Pressing "enter" in the search box wipes out input [Search] Pressing "enter" in the search box wipes out input Aug 8, 2023
zeh added a commit that referenced this issue Aug 11, 2023
@zeh
Search: pressing "Enter" on search field has better results
9bb0e90 
The logic when pressing the "Enter" key on search results is more user friendly.

- With no results: nothing (same as before)
- With one result: select that result and open the command (previously, it would reset the search input); that result always shows as selected (previously, it didn't)
- With more than one result: does nothing (previously, it would research the search input)

Closes #3.
@zeh
Copy link
Owner Author

zeh commented Aug 11, 2023

Fixed in 9bb0e90.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zeh zeh

Labels
bug Something isn't working
Projects
FFmpeg.app
Status: Released
Milestone
Beta
Development

No branches or pull requests
1 participant
@zeh