Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error when building for windows #15377

Closed
1 task done
tranvlnh26 opened this issue Jul 28, 2024 · 8 comments
Closed
1 task done

error when building for windows #15377

tranvlnh26 opened this issue Jul 28, 2024 · 8 comments
Labels
support User support (non-defect troubleshooting, documentation, etc) windows

Comments

@tranvlnh26
Copy link

Check for existing issues

  • Completed

Describe the bug / provide steps to reproduce it

image

Environment

Device name LAPTOP-48TGT8D1
Processor Intel(R) Core(TM) i5-10300H CPU @ 2.50GHz 2.50 GHz
Installed RAM 16.0 GB (15.8 GB usable)
Device ID 2CF61366-7D9C-4700-AC6C-529B253572E9
Product ID 00328-90000-00000-AAOEM
System type 64-bit operating system, x64-based processor
Pen and touch No pen or touch input is available for this display
Edition Windows 11 Enterprise
Version 23H2
Installed on ‎7/‎13/‎2024
OS build 22631.3880
Experience Windows Feature Experience Pack 1000.22700.1020.0

If applicable, add mockups / screenshots to help explain present your vision of the feature

No response

If applicable, attach your Zed.log file to this issue.

Zed.log
@tranvlnh26 tranvlnh26 added admin read Pending admin review defect [core label] triage Maintainer needs to classify the issue labels Jul 28, 2024
@notpeter
Copy link
Member

Which version of Rust are you using? That line changed in #15186:

Self(ArcCow::Owned(Arc::default()))

Which moved us from Rust 1.79 to Rust 1.80.
Arc::default() was added in Rust 1.80. source

@notpeter notpeter added windows support User support (non-defect troubleshooting, documentation, etc) and removed defect [core label] triage Maintainer needs to classify the issue admin read Pending admin review labels Jul 28, 2024
@tranvlnh26
Copy link
Author

image
how to update. I tried rustup and reinstalling but still no success

Which version of Rust are you using? That line changed in #15186:

Self(ArcCow::Owned(Arc::default()))

Which moved us from Rust 1.79 to Rust 1.80. Arc::default() was added in Rust 1.80. source

@JunkuiZhang
Copy link
Contributor

Please try recloning this repo.

@SomeoneToIgnore
Copy link
Contributor

This is not a Zed's issue.

A correctly working rustup is supposed to download a toolchain described in rust-toolchain.toml on the next cargo command in that directory.

If it does not (e.g. it could fail due to network error and start complaining about missing components on relaunch), remove the toolchain and try running any cargo command again.

If all that fails, install the toolchain version from rust-toolchain.toml manually with rustup and set an override to Zed's dir.
More information: https://rust-lang.github.io/rustup/concepts/toolchains.html

@SomeoneToIgnore SomeoneToIgnore closed this as not planned Won't fix, can't repro, duplicate, stale Jul 29, 2024
@tranvlnh26
Copy link
Author

Contributor

image
image

when checking with rustup it was 1.80 but rustc was 1.79

@stalkerg
Copy link

1.80 has some backward compatibility issues, this is why for example Gentoo have no a such update yet. rustup is fine but not for evyrbody (but should be ok on windows)

@osiewicz
Copy link
Contributor

What happens when you select a toolchain explicitly? e.g. cargo +1.80 build?

Though, as @SomeoneToIgnore, this is not a Zed issue.

@tranvlnh26
Copy link
Author

thank u, i did it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
support User support (non-defect troubleshooting, documentation, etc) windows
Projects
None yet
Development

No branches or pull requests

6 participants