Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add debug gRPC tracing - logging #492

Open
LarryRuane opened this issue Jul 27, 2024 · 0 comments · May be fixed by #494
Open

Add debug gRPC tracing - logging #492

LarryRuane opened this issue Jul 27, 2024 · 0 comments · May be fixed by #494
Labels
logging No functional change other than logging output testing

Comments

@LarryRuane
Copy link
Collaborator

There should be a way, either by command-line option or at runtime, to enable logging of gRPC calls. This idea is inspired by #491 in which it's unclear if the stuck zecwallet-lite instance is issuing gRPC calls that are not being handled correctly, or if it's not making any calls (or making incorrect calls).

This would also be useful for testing and development of lightwalletd clients.

We wouldn't want this enabled by default, because doing so would represent a denial of service (DoS) vulnerability, as a client could fill our log file with nonsense calls. This mode should not be preserved across lightwalletd restarts. If this mode is enabled dynamically (using a debug gRPC call), there should also be a way to disable it.

@LarryRuane LarryRuane added testing logging No functional change other than logging output labels Jul 27, 2024
@LarryRuane LarryRuane linked a pull request Aug 12, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
logging No functional change other than logging output testing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant