Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure symmetry of transparent output handling between put_blocks, store_decrypted_tx and store_sent_tx #1434

Open
nuttycom opened this issue Jun 22, 2024 · 2 comments
Open

Ensure symmetry of transparent output handling between put_blocks, store_decrypted_tx and store_sent_tx #1434

nuttycom opened this issue Jun 22, 2024 · 2 comments
Labels
S-in-progress Status: Work is currently in progress on this item.
Milestone
ZIP 320 and relat...

Comments

@nuttycom
Copy link
Contributor

nuttycom commented Jun 22, 2024 •
edited
Loading

AFAICT (at least as of the first commit in the PR), this NULL AS from_account_id is preserved, because there is still an asymmetry between transparent and shielded (we are not inserting transactions into both sent and received tables for transparent, in the same way we do for shielded). I think that asymmetry needs fixing prior to the next release (if not in this PR).

Originally posted by @str4d in #1402 (comment)

See also #1402 (comment)
@nuttycom nuttycom mentioned this issue Jun 22, 2024
Merged
@daira
Copy link
Contributor

daira commented Jun 27, 2024

Did merging #1402 fix this, or is there more to do?

@str4d
Copy link
Contributor

str4d commented Jul 25, 2024

There is still more to do; e.g. store_decrypted_tx does not update the received transparent outputs table. This causes an issue with ZIP 320 transactions, but it is also one that we might decide to stick with for the next release. I've marked this issue as blocking #1231 for us to decide whether we do finish this or bump it.

nuttycom added a commit to nuttycom/librustzcash that referenced this issue Jul 26, 2024
@nuttycom
zcash_client_sqlite: Store received UTXOs in store_decrypted_tx.
30a9fca 
This fixes an issue wherein transparent outputs of transactions added to
the wallet via `decrypt_and_store_transaction` would not be properly
recorded as UTXOs belonging to the wallet.

Fixes zcash#1434
@str4d str4d mentioned this issue Jul 26, 2024
Merged
nuttycom added a commit to nuttycom/librustzcash that referenced this issue Jul 26, 2024
@nuttycom
zcash_client_sqlite: Demonstrate the failure of store_decrypted_tx to…
f551167 
… persist transparent outputs.

Related to zcash#1434
nuttycom added a commit to nuttycom/librustzcash that referenced this issue Jul 26, 2024
@nuttycom
zcash_client_sqlite: Store received UTXOs in store_decrypted_tx.
d17c6d5 
This fixes an issue wherein transparent outputs of transactions added to
the wallet via `decrypt_and_store_transaction` would not be properly
recorded as UTXOs belonging to the wallet.

Fixes zcash#1434
@nuttycom nuttycom mentioned this issue Jul 26, 2024
Merged
nuttycom added a commit to nuttycom/librustzcash that referenced this issue Jul 26, 2024
@nuttycom
zcash_client_sqlite: Demonstrate the failure of store_decrypted_tx to…
46efb80 
… persist transparent outputs.

Related to zcash#1434
nuttycom added a commit to nuttycom/librustzcash that referenced this issue Jul 26, 2024
@nuttycom
zcash_client_sqlite: Store received UTXOs in store_decrypted_tx.
bda640c 
This fixes an issue wherein transparent outputs of transactions added to
the wallet via `decrypt_and_store_transaction` would not be properly
recorded as UTXOs belonging to the wallet.

Fixes zcash#1434
nuttycom added a commit to nuttycom/librustzcash that referenced this issue Jul 26, 2024
@nuttycom
zcash_client_sqlite: Store received UTXOs in store_decrypted_tx.
a3d4dc6 
This fixes an issue wherein transparent outputs of transactions added to
the wallet via `decrypt_and_store_transaction` would not be properly
recorded as UTXOs belonging to the wallet.

Fixes zcash#1434
nuttycom added a commit to nuttycom/librustzcash that referenced this issue Jul 26, 2024
@nuttycom
zcash_client_sqlite: Demonstrate the failure of store_decrypted_tx to…
5ad3205 
… persist transparent outputs.

Related to zcash#1434
nuttycom added a commit to nuttycom/librustzcash that referenced this issue Jul 26, 2024
@nuttycom
zcash_client_sqlite: Store received UTXOs in store_decrypted_tx.
3cec9ee 
This fixes an issue wherein transparent outputs of transactions added to
the wallet via `decrypt_and_store_transaction` would not be properly
recorded as UTXOs belonging to the wallet.

Part of zcash#1434
@str4d str4d added the S-in-progress Status: Work is currently in progress on this item. label Jul 31, 2024
@daira daira added this to the ZIP 320 and related changes milestone Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
S-in-progress Status: Work is currently in progress on this item.
Projects
None yet
Milestone
ZIP 320 and related changes
Development

No branches or pull requests
3 participants
@nuttycom @daira @str4d