-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Status): Add a method to create a Status instance from an integer #144
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -15,7 +15,7 @@ | |
<developerConnection>scm:git:[email protected]:zalando/problem.git</developerConnection> | ||
</scm> | ||
<properties> | ||
<jackson.version>2.9.8</jackson.version> | ||
<jackson.version>2.9.9</jackson.version> | ||
</properties> | ||
<dependencies> | ||
<dependency> | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,6 +3,7 @@ | |
import org.apiguardian.api.API; | ||
|
||
import javax.annotation.Nonnull; | ||
import java.util.Arrays; | ||
|
||
import static org.apiguardian.api.API.Status.MAINTAINED; | ||
|
||
|
@@ -268,6 +269,20 @@ public enum Status implements StatusType { | |
this.reason = reasonPhrase; | ||
} | ||
|
||
/** | ||
* Creates a Status instance from the given code. | ||
* | ||
* @param code the HTTP code as a number | ||
* @return the correct enum value for this status code. | ||
* @throws IllegalArgumentException if the given code does not correspond to a known HTTP status. | ||
*/ | ||
public static Status ofCode(int code) { | ||
return Arrays.stream(Status.values()) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Personally I'm not a big fan of linear search. What about constructing a map in a static initializer which we just use here? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm not used to do that but I can see why it'd be better in most cases. I'll make the change. |
||
.filter(status -> status.getStatusCode() == code) | ||
.findFirst() | ||
.orElseThrow(() -> new IllegalArgumentException("There is no known status for this code (" + code + ").")); | ||
} | ||
|
||
/** | ||
* Get the associated status code. | ||
* | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should mention a
@throws
section, imo.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, I'll add it.