Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Minimum Required Requests Version to 2.25.0 #55

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

btstevens89
Copy link

With #49, the underlying urllib3 minimum version required increased to 1.26.0. Requests 2.25.0 is the first version that pulls in urllib3 1.26.0.

urllib3 1.26.0 (2020-11-10) https://urllib3.readthedocs.io/en/latest/changelog.html#id6

Deprecated Retry options Retry.DEFAULT_METHOD_WHITELIST, Retry.DEFAULT_REDIRECT_HEADERS_BLACKLIST and 
Retry(method_whitelist=...) in favor of Retry.DEFAULT_ALLOWED_METHODS, Retry.DEFAULT_REMOVE_HEADERS_ON_REDIRECT,
and Retry(allowed_methods=...) (Pull #2000) Starting in urllib3 v2.0: Deprecated options will be removed

Requests 2.25.0 (2020-11-11) https://docs.python-requests.org/en/latest/community/updates/#id3

Dependencies
    Requests now supports urllib3 v1.26.

@@ -2,7 +2,7 @@

setup(
name='splunk_handler',
version='3.0.0',
version='3.0.1',
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go ahead and revert this change. I'll bump the version in a separate commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants