Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle websocket reconnects properly #6

Open
yuvipanda opened this issue Oct 17, 2020 · 0 comments
Open

Handle websocket reconnects properly #6

yuvipanda opened this issue Oct 17, 2020 · 0 comments

Comments

@yuvipanda
Copy link
Owner

Sometimes our websocket connection will die. In those circumstances, we should:

  1. Try reconnect websocket a few times, exponentially backing off with jitter. This should actually work, since terminado will maintain state.
  2. Close terminado (again, with retries) and disconnect ssh client.

We should try do this from the very beginning as much as possible
yuvipanda added a commit that referenced this issue Oct 18, 2020
@yuvipanda
Close SSH connection cleanly when user exits
756f3bf 
When the websocket connection breaks, we want to kill the
ssh client connection as well. I think this matches how
ssh works most clearly for now.

I don't trust my asyncio chops enough to know if this is
actually correct, though.

Ref #6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@yuvipanda