Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support running non-interactive commands #41

Open
yuvipanda opened this issue Jul 21, 2021 · 1 comment
Open

Support running non-interactive commands #41

yuvipanda opened this issue Jul 21, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@yuvipanda
Copy link
Owner

If you run ssh <hostname> echo hi, users expect it to log in, run just that command, show its output, and log out. No interactive terminal is needed.

Right now, jupyterhub-ssh always puts you in an interactive terminal. This is not expected behavior.

We communicate with the notebook server using the terminado api used by terminals in jupyter notebook. It defaults to setting up for interactive use. We can instead wrap the user command in something that runs it non-interactively, and close our connection when that is done.

This might help with stuff like rsync not working

@fperez
Copy link

fperez commented Jul 21, 2021

Excellent, thanks for filing this issue Yuvi! Along these lines, I am not sure if there are any differences as of today, but it's worth checking that the environment is also handled similarly to "normal" ssh - I know in the past I've had to set things up carefully handling env variables for the ssh host...

I agree that conforming to this interactive/non behavior should help with multiple things that tunnel through ssh (rsync and friends). Thx again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants