OpenTracing Tutorial - Node.js Lesson 3 RPC not updated yet ?

[lwmxiaobei]

OpenTracing Tutorial - Node.js Lesson 3 RPC not updated yet ?
I am more interested in rpc call, can you update it?

[yurishkuro]

Http requests should use FORMAT_HTTP_HEADERS

[a1300]

@yurishkuro you are right. Should I hide my comment?

I am using js-libp2p which uses no http and directly communicates over tcp. Therefore it worked for me with opentracing.FORMAT_TEXT_MAP. Can we add an example for opentracing.FORMAT_TEXT_MAP in the Lesson 3 (nodejs)?

[yurishkuro]

If you are using non-HTTP protocol that does not impose header restrictions the way HTTP does, then you should use text map format.

I am not sure why we'd add examples for text map here since this tutorial uses only HTTP.

Overall the Node.js tutorial is under-developed, if you look at Go tutorial, its README files have a lot more narrative / explanations.

[a1300]

@yurishkuro can you maybe create a ticket which things are missing for the node.js tutorial? I am ready to contribute. Or should I simply compare the node.js tutorial to e.g. the Go tutorial and then add the missing things?

[yurishkuro]

yes, simply compare Node.js README's with other languages, you will see that it has a low less narrative/explanations.