Add support for input event simulation. #1892
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA is valid! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use 'input' event instead of 'keyup' in our project because we don't support old browsers and input event handles cases like copy paste. We wanted to write tests for our modules but currently there's no way to simulate "input" event so we're kind of stuck there.
I've tested this code locally and it works fine. But I'm not totally sure about the side-effects of this change.
So I was hoping to get a guidance and some discussion in this pull-request.
I couldn't figure out what happens to people who don't use "node-event-html5" module. I'd guess they'd still be able to simulate the event but won't be able to listen to it.
I haven't setup a complete yeti test environment for yui so I couldn't run tests on this.