Print exceptions and pass exception error object into results #1845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When trying to fix a failing test, it is extremely important to know the call stack of any occurring exceptions; just knowing the error message is usually not enough to pin point the problem, so it would be useful also have access to the exception itself.
|
CLA is valid! |
aljimenez
changed the title
| @@ -99,7 +99,7 @@ if (!YUI.YUITest) { | |||
| break; | |||
|
|
|||
| case this.TEST_FAIL_EVENT: | |||
| message = event.testName + ": failed.\n" + event.error.getMessage(); | |||
| message = event.testName + ": failed.\n" + event.error.stack; | |||
There was a problem hiding this comment.
It is much more useful to see the stack, when trying to fix failing tests.
|
Perhaps you should make a PR for yui/yuitest repo. @caridy is working to sync up between yui/yui3 and yui/yuitest. See yui/yuitest#26. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to fix a failing test, it is extremely important to know the call stack of any occurring exception; just knowing the error message is usually not enough to pin point the problem, so it would be useful if exceptions are printed and if results have access to the exception itself.