Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update BoringSSL from Chromium 70.0.3538.110 #2102

Merged
merged 4 commits into from
Dec 15, 2023
Merged

Update BoringSSL from Chromium 70.0.3538.110 #2102

merged 4 commits into from
Dec 15, 2023

Conversation

dahlstrom-g
Copy link
Contributor

@dahlstrom-g dahlstrom-g commented Dec 14, 2023 •
edited
Loading

b/309016038

@dahlstrom-g
Publish DEPS for 70.0.3538.110
29bff04 
git-subtree-dir: third_party/boringssl
git-subtree-split: ec3092c8d21e20e39698f5272c8a7f71c3ee88a2
@dahlstrom-g dahlstrom-g force-pushed the boringssl-70.0.3538.110 branch 3 times, most recently from cb8052e to 571b1b7 Compare December 15, 2023 00:00
@dahlstrom-g dahlstrom-g marked this pull request as ready for review December 15, 2023 01:00
@andrewsavage1
Copy link
Contributor

Please create a separate bug for this instead of using the base/net update bug. Feel free to reuse/retitle b/309016038 if you want.

@dahlstrom-g
Copy link
Contributor Author

Please create a separate bug for this instead of using the base/net update bug. Feel free to reuse/retitle b/309016038 if you want.

done

@andrewsavage1
Copy link
Contributor

As long as this also passes internal builds it seems fine

@dahlstrom-g
Copy link
Contributor Author

As long as this also passes internal builds it seems fine

I checked that yesterday and it will but it needs approval.

@andrewsavage1
Copy link
Contributor

As long as this also passes internal builds it seems fine

I checked that yesterday and it will but it needs approval.

All the tests look like they failed on PS11

@dahlstrom-g
Copy link
Contributor Author

All the tests look like they failed on PS11

It took me a while to decide that wasn't some PlayStation. 😀
I guess you mean patch set 11 of the Gerrit change—
never mind that; I didn't intend for those to run there.
It's on submitters to make sure sure builds succeed
but reviewers are not generally responsible for that.

@dahlstrom-g dahlstrom-g merged commit 250ad6a into youtube:main Dec 15, 2023
318 of 329 checks passed
@dahlstrom-g dahlstrom-g deleted the boringssl-70.0.3538.110 branch December 15, 2023 20:00
kaidokert
kaidokert reviewed Aug 17, 2024
View reviewed changes
third_party/boringssl/BUILD.gn
"BORINGSSL_ALLOW_CXX_RUNTIME",
"BORINGSSL_IMPLEMENTATION",
"BORINGSSL_NO_STATIC_INITIALIZER",
"OPENSSL_SMALL",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This caused a significant regression - see b/360241262

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaidokert kaidokert kaidokert left review comments

@andrewsavage1 andrewsavage1 andrewsavage1 approved these changes

@briantting briantting Awaiting requested review from briantting

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dahlstrom-g @andrewsavage1 @kaidokert