Define OPENSSL_NO_ASM for PS5 modular builds #2016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: Id9625baa5734fcf8e057e1ecdc7d92072d7826d9
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2016 +/- ##
=======================================
Coverage 57.69% 57.69%
=======================================
Files 1907 1907
Lines 95181 95181
=======================================
+ Hits 54910 54917 +7
+ Misses 40271 40264 -7 ☔ View full report in Codecov by Sentry. |
y4vor
reviewed
Nov 30, 2023
kaidokert
approved these changes
Dec 1, 2023
cobalt-github-releaser-bot
pushed a commit
that referenced
this pull request
Dec 1, 2023
b/246412559 PS5 modular builds fail to run browser_test without this change , details in b/246412559#comment57 (cherry picked from commit a56372f)
niranjanyardi
added a commit
that referenced
this pull request
Dec 4, 2023
…2038) Refer to the original PR: #2016 b/246412559 PS5 modular builds fail to run browser_test without this change , details in b/246412559#comment57 Co-authored-by: Niranjan Yardi <[email protected]>
Rongo-JL
pushed a commit
to Rongo-JL/cobalt
that referenced
this pull request
Dec 19, 2023
b/246412559 PS5 modular builds fail to run browser_test without this change , details in b/246412559#comment57
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
b/246412559
PS5 modular builds fail to run browser_test without this change , details in b/246412559#comment57