Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add various DOM and Web tests. #2001

Merged
merged 2 commits into from
Dec 1, 2023
Merged

Conversation

jellefoks
Copy link
Member

@jellefoks jellefoks commented Nov 20, 2023

b/312288290

Copy link

codecov bot commented Nov 20, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (5741f3a) 57.69% compared to head (5a99d6b) 58.15%.
Report is 2 commits behind head on main.

Files Patch % Lines
cobalt/web/message_port.h 94.44% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2001      +/-   ##
==========================================
+ Coverage   57.69%   58.15%   +0.45%     
==========================================
  Files        1907     1907              
  Lines       95181    95200      +19     
==========================================
+ Hits        54912    55360     +448     
+ Misses      40269    39840     -429     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jellefoks jellefoks force-pushed the messageport_test branch 8 times, most recently from 34f43eb to 1aff903 Compare November 21, 2023 19:43
@jellefoks jellefoks changed the title Add MessagePort test Add various DOM and Web tests. Nov 21, 2023
@jellefoks jellefoks force-pushed the messageport_test branch 2 times, most recently from 7a7360a to d06cab7 Compare November 22, 2023 01:27
@jellefoks jellefoks force-pushed the messageport_test branch 8 times, most recently from 539e185 to 78793b6 Compare November 29, 2023 21:43
Copy link
Contributor

@oxve oxve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Three minor comments

cobalt/dom/html_element_style_test.cc Outdated Show resolved Hide resolved
cobalt/persistent_storage/persistent_settings.cc Outdated Show resolved Hide resolved
starboard/common/file.cc Outdated Show resolved Hide resolved
@oxve
Copy link
Contributor

oxve commented Dec 1, 2023

0.45% coverage increase is huge! Thanks for putting this together Jelle!

@jellefoks jellefoks merged commit 0cc8357 into youtube:main Dec 1, 2023
333 of 334 checks passed
@jellefoks jellefoks deleted the messageport_test branch December 1, 2023 22:12
Rongo-JL pushed a commit to Rongo-JL/cobalt that referenced this pull request Dec 19, 2023
Various additions to test coverage. This improves overall unit test coverage by 0.46%.

b/312288290
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants