-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement unshipped messages in message port. #1965
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jellefoks
force-pushed
the
unshipped_messages
branch
from
November 11, 2023 01:26
a9529d7
to
e4d3ac7
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
jellefoks
force-pushed
the
unshipped_messages
branch
from
November 15, 2023 18:59
e4d3ac7
to
462d81a
Compare
jellefoks
force-pushed
the
unshipped_messages
branch
from
November 16, 2023 17:49
462d81a
to
3b9dd00
Compare
sideb0ard
approved these changes
Nov 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor comments, lgtm
Implement storage of unshipped message in message port, to allow a message port to receive and hold messages before the destination is ready to receive them. Use the above functionality to unblock worker.postMessage calls to no longer wait until the worker script completes loading and executing. b/310240306
jellefoks
force-pushed
the
unshipped_messages
branch
from
November 17, 2023 00:49
3aa9a67
to
69fb04b
Compare
cobalt-github-releaser-bot
pushed a commit
that referenced
this pull request
Nov 17, 2023
Implement storage of unshipped message in message port, to allow a message port to receive and hold messages before the destination is ready to receive them. Use the above functionality to unblock worker.postMessage calls to no longer wait until the worker script completes loading and executing. b/310240306 b/226640425 (cherry picked from commit fbe1ba5)
jellefoks
added a commit
that referenced
this pull request
Nov 29, 2023
…1998) Refer to the original PR: #1965 Implement storage of unshipped message in message port, to allow a message port to receive and hold messages before the destination is ready to receive them. Use the above functionality to unblock worker.postMessage calls to no longer wait until the worker script completes loading and executing. b/310240306 b/226640425 Co-authored-by: Jelle Foks <[email protected]>
Rongo-JL
pushed a commit
to Rongo-JL/cobalt
that referenced
this pull request
Dec 19, 2023
Implement storage of unshipped message in message port, to allow a message port to receive and hold messages before the destination is ready to receive them. Use the above functionality to unblock worker.postMessage calls to no longer wait until the worker script completes loading and executing. b/310240306 b/226640425
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement storage of unshipped message in message port, to allow a message port to receive and hold messages before the destination is ready to receive them.
Use the above functionality to unblock worker.postMessage calls to no longer wait until the worker script completes loading and executing.
b/310240306
b/226640425