Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement unshipped messages in message port. #1965

Merged
merged 3 commits into from
Nov 17, 2023

Conversation

jellefoks
Copy link
Member

@jellefoks jellefoks commented Nov 11, 2023

Implement storage of unshipped message in message port, to allow a message port to receive and hold messages before the destination is ready to receive them.

Use the above functionality to unblock worker.postMessage calls to no longer wait until the worker script completes loading and executing.

b/310240306
b/226640425

This comment was marked as off-topic.

@jellefoks

This comment was marked as resolved.

@jellefoks

This comment was marked as resolved.

Copy link
Contributor

@sideb0ard sideb0ard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comments, lgtm

cobalt/web/message_port.h Outdated Show resolved Hide resolved
cobalt/web/message_port.h Outdated Show resolved Hide resolved
@jellefoks jellefoks enabled auto-merge (squash) November 17, 2023 00:03
Implement storage of unshipped message in message port, to allow a
message port to receive and hold messages before the destination is
ready to receive them.

Use the above functionality to unblock worker.postMessage calls to no
longer wait until the worker script completes loading and executing.

b/310240306
@jellefoks jellefoks merged commit fbe1ba5 into youtube:main Nov 17, 2023
331 of 332 checks passed
@jellefoks jellefoks added the cp-24.lts.1+ Cherry Pick to the 24.lts.1+ branch label Nov 17, 2023
cobalt-github-releaser-bot pushed a commit that referenced this pull request Nov 17, 2023
Implement storage of unshipped message in message port, to allow a
message port to receive and hold messages before the destination is
ready to receive them.

Use the above functionality to unblock worker.postMessage calls to no
longer wait until the worker script completes loading and executing.

b/310240306
b/226640425

(cherry picked from commit fbe1ba5)
jellefoks added a commit that referenced this pull request Nov 29, 2023
…1998)

Refer to the original PR: #1965

Implement storage of unshipped message in message port, to allow a
message port to receive and hold messages before the destination is
ready to receive them.

Use the above functionality to unblock worker.postMessage calls to no
longer wait until the worker script completes loading and executing.

b/310240306
b/226640425

Co-authored-by: Jelle Foks <[email protected]>
Rongo-JL pushed a commit to Rongo-JL/cobalt that referenced this pull request Dec 19, 2023
Implement storage of unshipped message in message port, to allow a
message port to receive and hold messages before the destination is
ready to receive them.

Use the above functionality to unblock worker.postMessage calls to no
longer wait until the worker script completes loading and executing.

b/310240306
b/226640425
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cp-24.lts.1+ Cherry Pick to the 24.lts.1+ branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants