Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Separate out modular and evergreen test targets" #1873

Merged
merged 1 commit into from
Oct 30, 2023

Conversation

oxve
Copy link
Contributor

@oxve oxve commented Oct 30, 2023

Reverts #1662

elf_loader_test is needed by non-evergreen test runs too, though it shouldn't contain any tests.

b/302008891

@oxve oxve merged commit f64375a into main Oct 30, 2023
217 of 218 checks passed
@oxve oxve deleted the revert-1662-separate_eg_modular branch October 30, 2023 18:09
niranjanyardi added a commit that referenced this pull request Oct 31, 2023
niranjanyardi added a commit that referenced this pull request Nov 6, 2023
…1918)

Reverts #1873 partially
Internal failures have been fixed.

Note: For disabling evergreen specific tests for all non-evergreen
platforms b/309493306 needs to be fixed.
As a step in the right direction we are just disabling building
disabling evergreen specific tests for windows platforms at the moment.

b/302008891
cobalt-github-releaser-bot pushed a commit that referenced this pull request Nov 6, 2023
…1918)

Reverts #1873 partially
Internal failures have been fixed.

Note: For disabling evergreen specific tests for all non-evergreen
platforms b/309493306 needs to be fixed.
As a step in the right direction we are just disabling building
disabling evergreen specific tests for windows platforms at the moment.

b/302008891

(cherry picked from commit 34c46ca)
niranjanyardi added a commit that referenced this pull request Nov 7, 2023
…1918)

Reverts #1873 partially
Internal failures have been fixed.

Note: For disabling evergreen specific tests for all non-evergreen
platforms b/309493306 needs to be fixed.
As a step in the right direction we are just disabling building
disabling evergreen specific tests for windows platforms at the moment.

b/302008891

(cherry picked from commit 34c46ca)
niranjanyardi added a commit that referenced this pull request Nov 7, 2023
…non-windows platforms (#1924)

Refer to the original PR: #1918

Reverts #1873 partially
Internal failures have been fixed.

Note: For disabling evergreen specific tests for all non-evergreen
platforms b/309493306 needs to be fixed.
As a step in the right direction we are just disabling building
disabling evergreen specific tests for windows platforms at the moment.

b/302008891

Co-authored-by: Niranjan Yardi <[email protected]>
Rongo-JL pushed a commit to Rongo-JL/cobalt that referenced this pull request Dec 19, 2023
Reverts youtube#1662

`elf_loader_test` is needed by non-evergreen test runs too, though it
shouldn't contain any tests.

b/302008891
Rongo-JL pushed a commit to Rongo-JL/cobalt that referenced this pull request Dec 19, 2023
…outube#1918)

Reverts youtube#1873 partially
Internal failures have been fixed.

Note: For disabling evergreen specific tests for all non-evergreen
platforms b/309493306 needs to be fixed.
As a step in the right direction we are just disabling building
disabling evergreen specific tests for windows platforms at the moment.

b/302008891
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants