-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Separate out modular and evergreen test targets" #1873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 60a61d7.
kaidokert
approved these changes
Oct 30, 2023
niranjanyardi
added a commit
that referenced
this pull request
Oct 31, 2023
…)" This reverts commit f64375a.
This was referenced Oct 31, 2023
niranjanyardi
added a commit
that referenced
this pull request
Nov 6, 2023
…1918) Reverts #1873 partially Internal failures have been fixed. Note: For disabling evergreen specific tests for all non-evergreen platforms b/309493306 needs to be fixed. As a step in the right direction we are just disabling building disabling evergreen specific tests for windows platforms at the moment. b/302008891
cobalt-github-releaser-bot
pushed a commit
that referenced
this pull request
Nov 6, 2023
…1918) Reverts #1873 partially Internal failures have been fixed. Note: For disabling evergreen specific tests for all non-evergreen platforms b/309493306 needs to be fixed. As a step in the right direction we are just disabling building disabling evergreen specific tests for windows platforms at the moment. b/302008891 (cherry picked from commit 34c46ca)
niranjanyardi
added a commit
that referenced
this pull request
Nov 7, 2023
…1918) Reverts #1873 partially Internal failures have been fixed. Note: For disabling evergreen specific tests for all non-evergreen platforms b/309493306 needs to be fixed. As a step in the right direction we are just disabling building disabling evergreen specific tests for windows platforms at the moment. b/302008891 (cherry picked from commit 34c46ca)
niranjanyardi
added a commit
that referenced
this pull request
Nov 7, 2023
…non-windows platforms (#1924) Refer to the original PR: #1918 Reverts #1873 partially Internal failures have been fixed. Note: For disabling evergreen specific tests for all non-evergreen platforms b/309493306 needs to be fixed. As a step in the right direction we are just disabling building disabling evergreen specific tests for windows platforms at the moment. b/302008891 Co-authored-by: Niranjan Yardi <[email protected]>
Rongo-JL
pushed a commit
to Rongo-JL/cobalt
that referenced
this pull request
Dec 19, 2023
Reverts youtube#1662 `elf_loader_test` is needed by non-evergreen test runs too, though it shouldn't contain any tests. b/302008891
Rongo-JL
pushed a commit
to Rongo-JL/cobalt
that referenced
this pull request
Dec 19, 2023
…outube#1918) Reverts youtube#1873 partially Internal failures have been fixed. Note: For disabling evergreen specific tests for all non-evergreen platforms b/309493306 needs to be fixed. As a step in the right direction we are just disabling building disabling evergreen specific tests for windows platforms at the moment. b/302008891
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #1662
elf_loader_test
is needed by non-evergreen test runs too, though it shouldn't contain any tests.b/302008891