From 5eb5f808fa2c49873e5cebc89b7ea06f118908c2 Mon Sep 17 00:00:00 2001 From: Niranjan Yardi Date: Tue, 7 Nov 2023 11:17:01 -0800 Subject: [PATCH] Add TODO statements from previous PR feedback (#1925) Adding TODO statements from feedback in https://github.com/youtube/cobalt/pull/1918 b/309493306 --- starboard/elf_loader/BUILD.gn | 2 ++ starboard/loader_app/BUILD.gn | 3 +++ 2 files changed, 5 insertions(+) diff --git a/starboard/elf_loader/BUILD.gn b/starboard/elf_loader/BUILD.gn index 7a23d24f3b62..9b1354f6e964 100644 --- a/starboard/elf_loader/BUILD.gn +++ b/starboard/elf_loader/BUILD.gn @@ -90,6 +90,7 @@ if (sb_is_evergreen_compatible) { } } +# TODO: b/309493306 - Stop building evergreen targets for all non-evergreen platforms. if (current_toolchain == starboard_toolchain && !is_host_win) { target(starboard_level_final_executable_type, "elf_loader_sandbox") { data_deps = [ "//third_party/icu:icudata" ] @@ -157,6 +158,7 @@ if (sb_is_evergreen_compatible) { } } +# TODO: b/309493306 - Stop building evergreen targets for all non-evergreen platforms. if (!is_host_win) { target(gtest_target_type, "elf_loader_test") { testonly = true diff --git a/starboard/loader_app/BUILD.gn b/starboard/loader_app/BUILD.gn index 6fd239b83bd7..415d51572a56 100644 --- a/starboard/loader_app/BUILD.gn +++ b/starboard/loader_app/BUILD.gn @@ -237,6 +237,7 @@ static_library("installation_manager") { ] } +# TODO: b/309493306 - Stop building evergreen targets for all non-evergreen platforms. if (!is_host_win) { target(gtest_target_type, "installation_manager_test") { testonly = true @@ -277,6 +278,7 @@ static_library("slot_management") { } } +# TODO: b/309493306 - Stop building evergreen targets for all non-evergreen platforms. if (!is_host_win) { target(gtest_target_type, "slot_management_test") { testonly = true @@ -326,6 +328,7 @@ static_library("reset_evergreen_update") { deps = [ "//starboard" ] } +# TODO: b/309493306 - Stop building evergreen targets for all non-evergreen platforms. if (!is_host_win) { target(gtest_target_type, "reset_evergreen_update_test") { testonly = true