Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added installer.py #318

Merged
merged 2 commits into from
Nov 8, 2024

Conversation

Denperidge
Copy link
Contributor

@Denperidge Denperidge commented Aug 24, 2024

Hi! Sorry I didn't make it in time for the latest release, but here is a first proper draft of an installer!

  • Allows overrides to be added from a different file
  • Automatic default profile backup, that can be disabled if wanted
  • The firefox version is automatically determined and used to fetch the latest Betterfox release that has compatibility noted in their release
  • Allows installing a specific Betterfox release
  • Compatible with any forks people might have, but as of now only as long as they use releases too.

What should be noted:

  • MacOS has not been tested, due to a lack of MacOS to test on
  • The compile for windows instructions should be expanded to clarify it only compiles for Windows when compiled on Windows, and change the cleanup commands to not use git bash. I'll do this later

This should hopefully create a one-click install for most users, whilst allowing advanced users to override any specifics

Instructions for creating a Windows exe are included. This has been tested in Windows 10 and NixOS 24.05 (Python 3.11).

Related: #167, #313

@Denperidge
Copy link
Contributor Author

Denperidge commented Aug 24, 2024

OH! If you (yokoffing) could check the TODO markers, that would be great! I wasn't sure about the compatibility of some of the patch releases 😌

@yokoffing
Copy link
Owner

Thanks Denperidge! I'll post for feedback on the 130 release.

@yokoffing
Copy link
Owner

yokoffing commented Oct 28, 2024

Apologies. It's a very busy season of life.

I was looking over the TODO:

  • The fix in v.122.1 applied to previous versions too. I called it .1 because I didn't want to wait to release until v.123, but it would apply to versions as far back as v.107. So not applicable here, if I'm understanding everything correctly.
  • v.116 and v.107 look correct.
  • As time goes on, we can probably remove those exceptions.

@Denperidge
Copy link
Contributor Author

Absolutely no problem! Very understandable, and I ended up taking a second to update the PR either way. But here we go!

@yokoffing yokoffing merged commit 429abb6 into yokoffing:main Nov 8, 2024
@yokoffing
Copy link
Owner

yokoffing commented Nov 8, 2024

@Denperidge, I've added a place for questions and feedback in #337.

Credited your work in v.132 README 17ae725.

Thanks again!

@Denperidge
Copy link
Contributor Author

Thank you so much too, and feel free to give me a ping on any improvements you’d like down the road! Will keep an eye on the discussion 😌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants