Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firefox Weather Widget not being blocked by Betterfox #311

Open
4 tasks done
FifthWit opened this issue Aug 1, 2024 · 4 comments · May be fixed by #321
Open
4 tasks done

Firefox Weather Widget not being blocked by Betterfox #311

FifthWit opened this issue Aug 1, 2024 · 4 comments · May be fixed by #321
Assignees

Comments

@FifthWit
Copy link

FifthWit commented Aug 1, 2024

BEFORE YOU BEGIN

I have attempted the following troubleshooting suggestions:

  • The issue persists when using Firefox in Troubleshoot Mode.
  • Disabled DNS-level content blocking (AdGuard Home, NextDNS, Control D, RethinkDNS, PiHole, etc), cleared my DNS cache, and used my ISP's DNS resolver (if applicable).
  • Cleared website data, restarted Firefox, and my issue persists.
  • I have created a new profile. The issue persists when using the current user.js file on GitHub. (Must be in a new profile and a new user.js!)

REPORT

Describe the bug
A clear and concise description of what the bug is.
A new FireFox feature (for me) added a widget with the weather at the top left of the new tab screen on a fresh install
To Reproduce
Steps to reproduce the behavior:

1. Go to 'Download FireFox'
2. Install BetterFox
3. Open New Tab
4. Look at the top left and it should have a weather widget in specific mine is sponsered by AccuWeather

Expected behavior
A clear and concise description of what you expected to happen.
The Widget would be gone along with all the data it takes
Screenshots
If applicable, add screenshots to help explain your problem.
image for gh issue
Desktop (please complete the following information):

  • OS: Windows 10 Home

  • Browser: FireFox

  • Version: 128.0.3 (64-bit)

Additional context
Add any other context about the problem here.
unsure if everyone has this but at least on the most recent version its appearing for me

@yokoffing
Copy link
Owner

yokoffing commented Aug 2, 2024

Documented, but doesn’t seem to be enabled in stable just yet:

Betterfox/Peskyfox.js

Lines 290 to 291 in abe7e9d

//user_pref("browser.newtabpage.activity-stream.showWeather", false); // Weather [FF128+ NIGHTLY]
//user_pref("browser.newtabpage.activity-stream.system.showWeather", false); // Weather [FF128+ NIGHTLY]

You can still turn it off in about:config or adding it to your personal user.js.

There also should be UI for this in the settings, if there isn't already.

@yokoffing
Copy link
Owner

This finally landed for me in today's update v. 130.

yokoffing added a commit that referenced this issue Sep 3, 2024
@winter-again
Copy link

Not sure if helpful, but (in ref. to the commit above) I had to specify browser.newtabpage.activity-stream.system.showWeather as false too to get the weather widget to go away.

@yokoffing
Copy link
Owner

yokoffing commented Sep 7, 2024

@winter-again I've tested on two systems with vanilla Firefox stable and once in Nightly, and I only had to use browser.newtabpage.activity-stream.showWeather. I've also confirmed that this is the pref that changes if you disable the Weather widget from the new tab page.

system.showWeather removes it altogether as an option from the gear icon on the new tab page (hides it in the UI).

yokoffing added a commit that referenced this issue Sep 7, 2024
@yokoffing yokoffing linked a pull request Sep 7, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants